Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Noetic release #4

Merged
merged 4 commits into from May 15, 2020
Merged

Noetic release #4

merged 4 commits into from May 15, 2020

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Apr 2, 2020

Following the guidelines to migrate packages to noetic

  • import setup from setuptools instead of distutils-core

  • Bump CMake version to avoid CMP0048 warning
    This bumps the minimum CMake version to 3.0.2, which is the minimum supported by ROS Kinetic and new enough to default to the NEW behavior of CMP0048. This avoids a CMake warning when building and testing this package in Debian Buster and Ubuntu Focal.

Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde self-assigned this Apr 2, 2020
setup.py Outdated Show resolved Hide resolved
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
@sloretz
Copy link
Contributor

sloretz commented May 15, 2020

@ablasdel this looks good to me, and is required by metapackages via rqt_robot_plugins, so I'm going to merge it and make a 0.5.8 release for Noetic. Hope that's ok.

@sloretz sloretz merged commit 23e70d9 into master May 15, 2020
@sloretz sloretz deleted the ahcorde/noetic_release branch May 15, 2020 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants