Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unit test data from the source repo #38

Closed
dirk-thomas opened this issue Aug 17, 2013 · 7 comments
Closed

remove unit test data from the source repo #38

dirk-thomas opened this issue Aug 17, 2013 · 7 comments
Assignees
Labels

Comments

@dirk-thomas
Copy link
Contributor

Test data files (which are more than some kB) do not belong into the source repo (e.g. bag files under rqt_robot_monitor/test). Please move them to an external location (e.g. pr.willowgarage.com/download) and download them using the functions provided by catkin. Also make sure to cleanly remove the related commits from the Git history. Increasing the Git repo by 20 MB forever is not acceptable.

@ghost ghost assigned 130s and dirk-thomas Aug 17, 2013
@dirk-thomas
Copy link
Contributor Author

@130s Please do NOT commit test data like this to the source repo.

I have reverted the Git repo to the state before your commit 70a9abb even is that is inconvenient for users after it has been pushed to public.

@130s
Copy link
Member

130s commented Aug 17, 2013

I see, and thanks for reverting.
Once the new data repo (ros/rosdistro#1614 (comment)) is ready I'll move .bag files there (I found using .bag files very nice for unit testing esp. for GUIs).

Out of curiosity where does "20" MB limit come from? I can't find it on git or github web pages.

@dirk-thomas
Copy link
Contributor Author

You should not wait for that ticket and deal with it now. There is no ETA on when this will be available and the current infrastructure is absolutely fine.

@130s
Copy link
Member

130s commented Aug 17, 2013

Ok, then how can I upload data to http://pr.willowgarage.com/data/ (I guess that location is what you meant)? I don't seem to find where I can.
DevelopersGuide says https://code.ros.org/gf/project/data is the right place that sounds outdated to me.

@130s
Copy link
Member

130s commented Aug 17, 2013

I asked on answers.

@mikeferguson
Copy link
Contributor

It's not a hard and fast limit -- it's just that every time someone checks out the repo they get that 20mb. Since pr.willowgarage.com is hard to upload to, perhaps you could create a second git repository like rqt_robot_plugins_testdata and put the bag in there, it won't affect users, and you can use github raw urls to access the bagfile.

@dirk-thomas
Copy link
Contributor Author

GitHub itself does explicitly not recommend doing that.

You can either select a location where the files is available for long-term or let @tfoote or me now and we put it on pr.willowgarage.com. Soon these files will move to a ros.org domain which makes it even easier for us to manage them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants