rqt_robot_dashboard: missing coloured battery status images

[bit-pirate]

in the SVG format for charging levels 60 to 100.
They already exist as PNG.

[ablasdel]

When those were made it was decided the grey worked better than the green. In hind sight just putting both would have been the smart option for re-usability.

If someone would like to edit the existing ones to change the color I would be perfectly happy to add them alongside the originals.

Until they have been submitted I will mark this as an untargeted enhancement

[bit-pirate]

Hm, I like colours! :-) And there is already a lot of grey in the robot_dashboard.

If I get you a pull request with the coloured versions, would you replace the standards with them? If not, then it wouldn't be worth the effort, since we are using the default battery widget in the turtlebot_dashboard (aka kobuki/create dashboard).

[ablasdel]

I can promise they will be included in the package alongside the other svg files. But for the main dashboards we put together we prefered the look of the grey. It shouldn't be too hard to switch which ones the kabuki uses after they are available.

[bit-pirate]

I'd like to avoid code duplication and extra work. So, as long as there is no big interest in the turtlebot community, I will consider this as unimportant. Thx for your quick feedback!

[ablasdel]

No code duplication required. Look at how pr2 dashboard creates its own battery widget. It should be only a few lines of code. If you have any issues contact me and I'll give you a hand.

[bit-pirate]

OK, you won! I added it.

Although you were right about the minimal extra amount of code being required, I had to fix bug #42 to get it all working.

You really know how to get people working for you! ;-)

[ablasdel]

Awesome! Seriously I get people to work for me in my sleep!

I have looked at the icons and they look great. I had actually sent an email to the guy who made them originally but you got back quicker!

If the icons were a separate pull request I would merge them immediately.
As it is I need to get another rqt developer to sign off on the bug fix code before I merge.