BatteryDashWidget not showing coloured images

[bit-pirate]

We use the BatteryDashWidget in both the create and kobuki dashboards. When the battery is running low (below 50%), the widget should be showing orange or red battery icons. However, only a slightly lighter grey image is shown.

I took a look at both the dashboard and the widget code, but couldn't find an obvious bug. Any idea what is causing this?

[ablasdel]

Unless I am mistaken the colors come on at 40% for orange and 20% for red don't they?

take that with a grain of salt as I am not at a computer currently.

I'll take a look at it tomorrow to make sure nothing is going wrong.

[bit-pirate]

Yes, that is what I expected, but they are not shown. I'll wait for your test result.

[bit-pirate]

Something goes wrong with the SVGs, since the PNGs work fine. Furthermore, colour is shown, but somehow a grey overlay is added (I added a red rectangle added in the free, white space). Not sure, what is adding this grey overlay though.

[bit-pirate]

OK, I finally figured this out. Two problems were involved:

First, disabling the QToolButton

class BatteryDashWidget(IconToolButton):
    [...]
    def __init__(self, name='Battery', icons=None, charge_icons=None, icon_paths=None):
        [...]
        self.setEnabled(False)

replaces the icon with a grey scale version by default. I applied the fix from this post: http://qt-project.org/forums/viewthread/4669

Second, something got messed up when I applied the green colour to the "charge bars". It was shown correctly in Inkscape, but not rendered correctly inside Qt. I ended up modifying the xml directly, since I'm not too familiar with Inkscape.

So finally I have coloured icons again. Yay! :-)

[ablasdel]

This is really interesting and I hadn't noticed this issue before. You have quite an impressive eye for detail.

[bit-pirate]

What do you think about this new version?