Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor cleanups in rqt_srv for ROS 2 #9

Merged
merged 2 commits into from Jun 7, 2023
Merged

Minor cleanups in rqt_srv for ROS 2 #9

merged 2 commits into from Jun 7, 2023

Conversation

clalancette
Copy link

This PR does 2 things:

  1. It cleans up the package description to be less ROS 1-specific, and fixes up dependencies to be more correct.
  2. It adds in the basic xmllint and flake8 tests, along with fixes for them.

@clalancette
Copy link
Author

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@clalancette
Cleanup.
07f9c61 
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
@clalancette
Add in tests.
a92e90c 
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
@clalancette clalancette requested a review from gbiggs as a code owner June 7, 2023 14:32
@clalancette
Copy link
Author

New CI after the rebase:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

quarkytale
quarkytale approved these changes Jun 7, 2023
View reviewed changes
Copy link

@quarkytale quarkytale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@clalancette clalancette merged commit 85b2b47 into rolling Jun 7, 2023
1 check passed
@clalancette clalancette deleted the clalancette/cleanup branch June 7, 2023 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quarkytale quarkytale quarkytale approved these changes

@gbiggs gbiggs Awaiting requested review from gbiggs gbiggs is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@clalancette @quarkytale