Fix removal of topics while they are being monitored. #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change, if a topic was being monitored by rqt_topic and then went away, it would stay in the window forever. The main reason for this is that the subscription that rqt_topic itself is using counts as one of the topics in the graph, and so it wasn't "empty" to be deleted. To fix this, we notice that for every topic we are currently monitoring, there should be at least one additional publisher or subscription in the graph besides rqt_topic. If there is, then we continue monitoring. If there isn't, we delete the topic. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
audrow
approved these changes
Apr 27, 2022
|
CI:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, if a topic was being monitored by rqt_topic
and then went away, it would stay in the window forever. The main
reason for this is that the subscription that rqt_topic itself
is using counts as one of the topics in the graph, and so it wasn't
"empty" to be deleted. To fix this, we notice that for every
topic we are currently monitoring, there should be at least one
additional publisher or subscription in the graph besides rqt_topic.
If there is, then we continue monitoring. If there isn't, we
delete the topic.
Signed-off-by: Chris Lalancette clalancette@openrobotics.org