Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix removal of topics while they are being monitored. #39

Merged
merged 1 commit into from Apr 28, 2022
Merged

Fix removal of topics while they are being monitored. #39

merged 1 commit into from Apr 28, 2022

Commits on Apr 27, 2022

  1. Fix removal of topics while they are being monitored. 

    Prior to this change, if a topic was being monitored by rqt_topic
and then went away, it would stay in the window forever.  The main
reason for this is that the subscription that rqt_topic itself
is using counts as one of the topics in the graph, and so it wasn't
"empty" to be deleted.  To fix this, we notice that for every
topic we are currently monitoring, there should be at least one
additional publisher or subscription in the graph besides rqt_topic.
If there is, then we continue monitoring.  If there isn't, we
delete the topic.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
    @clalancette
    clalancette committed Apr 27, 2022
    Configuration menu
    Copy the full SHA
    6489fcd View commit details
    Browse the repository at this point in the history