Nogp update #1063
Merged
Nogp update #1063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I ran into the same problem with Ogre 1.10 on Arch. It would be great if this could be merged. The second commit is not needed anymore though since #1092 is merged. It would make sense to drop it from the PR. It even appears to be an empty commit? |
|
Awesome, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue posted here.
As mentioned, the install is non-standard (Ogre 1.10), which might explain why I also had to modify
mesh_shape.cppto includeOgreMesh.h. I was getting a forward declaration build error for Ogre::Mesh.Also, I have not tested the effects on the affected
nogpprocesses, but a standard install allowed me to run rviz on El Capitan with no problems, including correct image rendering.