Fix opacity of Collada meshes #1387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an issue introduced in ros-visualization#1294 (e906f82): Materials of Collada mesh models need to be cloned for each instance of a robot link.
| { | ||
| // create a new material copy for each instance of a RobotLink | ||
| Ogre::MaterialPtr mat = Ogre::MaterialPtr(new Ogre::Material(nullptr, material_name, 0, ROS_PACKAGE_NAME)); | ||
| *mat = *sub->getMaterial(); |
There was a problem hiding this comment.
I have to admit I don't quite understand this line
There was a problem hiding this comment.
Create a new material instance and copy the existing material into this instance.
There was a problem hiding this comment.
ah, ok, thanks, I was reading to much into the first line/constructor
|
@rhaschke good job, works as expected now. Thanks! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue introduced in #1294 (e906f82):
Materials of Collada mesh models need to be cloned for each instance of a robot link.
Fixes #1385. @simonschmeisser, could you please verify?