Robot: Report mesh loading issues #1629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I haven't found the time to test it yet unfortunately. Generally I don't mind that much about how we present the errors. My version might be a bit simpler to parse for further use in our URDF editor but this one can also be regexed. I wonder if that variadic function could be avoided by switching to QString right from the beginning, can open a PR on Monday evening |
|
Which variadic function you are referring to? |
| errors.erase(this); | ||
| } | ||
|
|
||
| void RobotLink::addError(const char* format, ...) |
There was a problem hiding this comment.
I was referring to this variadic function that could be simplified by using QString or QStringList
| loadMeshFromResource(model_name); | ||
| entity = scene_manager_->createEntity(ss.str(), model_name); | ||
| if (loadMeshFromResource(model_name).isNull()) | ||
| addError("Could not load mesh resource '%s'", model_name.c_str()); |
There was a problem hiding this comment.
Suggested change
| addError("Could not load mesh resource '%s'", model_name.c_str()); | |
| addError(QString("Could not load mesh resource '%1'").arg(model_name.c_str())); |
or so, just a suggestion to keep things simple
|
Thanks for merging this! I was too busy with other stuff before my holidays unfortunately to open yet another PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements #1597 (comment) and fixes #1589.
@simonschmeisser, please have a look. I decided to summarize all mesh loading issues as part of the URDF field.
As you noticed in #1597, TF updates to the link status will overwrite previous errors and introducing a new status field, I didn't like so much.