Fix for tf display not loading frame config #946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…perly read from the config file. Updated the display to read the value, store the values in a map, and use the map to update the enabled/disabled state of the frame once the frame is added. This properly handles frames which are not published at the time the tf display is created.
|
Thanks @bponsler. I've just given this a quick test on some of my complex use cases with a humanoid robot, and real-life situations with intense use of the tf graph. As far as I can see, this seems to work as expected and provide a decent simple solution to this longstanding problem. |
|
I tested this out locally and it works great for me too. I think the code changes make sense too. So I'm going to merge this and close #938 in favor of this. Thanks @bponsler and @arntanguy for your work on this! |
wjwwood
added a commit
that referenced
this pull request
Dec 10, 2015
Fix for tf display not loading frame config
This was referenced Dec 10, 2015
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for issue #834 using the changes from PR #938 by @arntanguy with the following modifications:
Because no new frames are created when loading the config this properly handles the case where frames specified in the config file are not published at the time the config is read mentioned in PR #938.
This also handles the case (mentioned by @hersh) where the set of frames specified in the config file are different than the set of frames being actively published. Since no new frames are created based on the config file only the intersection of those two sets will have their enabled state modified, and only the frames being actively published will be added to the display.