Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #959: jumping marker in MOVE_3D mode #961

Merged

Conversation

rhaschke
Copy link
Contributor

@rhaschke rhaschke commented Jan 5, 2016

Initial fix for #959: jumping interactive marker in MOVE_3D mode.
I need to check whether other modes are affected too.

@rhaschke
Copy link
Contributor Author

rhaschke commented Jan 5, 2016

+1
All other modes worked (and still work) fine. I tested with standard basic_controls example,
defining base_link as a non-root frame in rviz. The only issue was with MOVE_3D and MOVE_ROTATE_3D when moving.

@rhaschke
Copy link
Contributor Author

rhaschke commented Mar 7, 2016

@wjwwood Could you please review this fix for #959 and consider it for merging?

@wjwwood
Copy link
Member

wjwwood commented Mar 7, 2016

Yeah, I'm currently working through the backlog. I want to get through them and make a release this week, so that I can fork for Qt5 and Kinetic.

@wjwwood
Copy link
Member

wjwwood commented Mar 22, 2016

Ok, I was able to reproduce this and see that this fixes the issue. Thanks!

I'm going to merge this, but @rhaschke if you have time, can you comment on how #935 and #937 related to this issue. They seem very similar, but I haven't looked into those just yet.

wjwwood added a commit that referenced this pull request Mar 22, 2016
fix #959: jumping marker in MOVE_3D mode
@wjwwood wjwwood merged commit b63f2e0 into ros-visualization:indigo-devel Mar 22, 2016
@rhaschke
Copy link
Contributor Author

@wjwwood, indeed #935 and #937 describe exactly the same issue - I didn't see them when browsing the issue history. @jjnak found a quite similar solution to mine - removing the variable parent_to_grab_position_. However, his modification of the view plane computation results in strange results: If the reference frame is rotated, mouse motion in the view plane result in translations in depth instead of xy of view plane.

@rhaschke rhaschke deleted the fix-jumping-imarker branch March 30, 2016 06:44
@jjnak
Copy link

jjnak commented Oct 13, 2016

Sorry for my delayed response. I've tried the current indigo-devel and it works very well. @rhaschke and @wjwwood, thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants