Queue-Sizes Configurable Through Parameters #47
Conversation
| int pub_queue_size; | ||
| int sub_queue_size; | ||
| n_.param("actionlib_client_pub_queue_size", pub_queue_size, 1); | ||
| n_.param("actionlib_client_sub_queue_size", sub_queue_size, 10); |
There was a problem hiding this comment.
Should the default values be the other way around?
There was a problem hiding this comment.
@safrimus You are absolutely right. I apologize for waiting three days to respond to this, I didn't see it... Will fix right now.
There was a problem hiding this comment.
I made the changes and did a rebase, but it's not currently showing up on Github. I cloned the repository to a new directory to test, and my changes show up there. I'll let Github's front end have a few hours to register the change.
Jmeyer1292
force-pushed
the
queue_size_config
branch
from
752978c
to
a81be10
Compare
|
@ros-pull-request-builder can you retest this now that merge conflicts have been resolved? |
action client and action server's C++ implementation.
Jmeyer1292
force-pushed
the
queue_size_config
branch
from
a81be10
to
425ff82
Compare
|
I did a reword on the commit message in order to trigger a new test round. |
|
Sorry for the delay. Is it possible to add a basic test/launchfile, setting the queue-sizes through parameters? |
|
@Jmeyer1292 would you mind adding the same configuration on the python server/client for feature parity? Otherwise I'll open a PR against your branch before merging this |
|
@mikaelarguedas Now I'm sorry for the delays. I will attempt to address both the test launch files and the python feature parity. |
|
@Jmeyer1292 FYI: created another pull request with the changes discussed on Jun 22nd |
|
@mikaelarguedas +1, thanks for carrying this forward. |
|
closing this in favor or #55 |
Greetings,
Per #46, this PR allows the user of a ROS action server or action client to configure the queue size of all publishers / subscribers through a parameter interface.
Specifically,
actionlib_server_sub_queue_size,actionlib_server_pub_queue_size,actionlib_client_sub_queue_size, andactionlib_client_pub_queue_sizemay be set. If these parameters are not set, the assumed defaults make the behaviour of the library identical to the current logic.I understand
actionlibis core infrastructure for the ROS community, and I will work with you as necessary to make this PR satisfactory if it is not already. Please review and provide feedback.