fix rollback of environment when workspace has been deleted #641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
|
Testing this now. |
|
What is the easiest way to test this without uninstalling catkin? |
|
Just clone catkin into a workspace and build that ontop of what is already installed. It will overlay the installed version of catkin. Then you can use the same sequence ontop which you used to reproduce the problem. |
|
Yeah it looks like this fixes it! |
|
+1 good to merge |
dirk-thomas
added a commit
that referenced
this pull request
Jun 1, 2014
fix rollback of environment when workspace has been deleted
cwecht
pushed a commit
to cwecht/catkin
that referenced
this pull request
Mar 20, 2018
Adds a launch file to test the entire grpc bridge.
Here is an example to run:
```
catkin_make_isolated --use-ninja -DBUILD_GRPC=True
source devel_isolated/setup.bash
roslaunch cartographer_ros grpc_demo_backpack_2d.launch bag_filename:=${HOME}/Downloads/cartographer_paper_deutsches_museum.bag
```
The bash script is a work-around to run an executable outside of the catkin packages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jbohren Please verify that this patch address the issue you were able to reproduce in catkin/catkin_tools#47 (comment)