Use .empty() to check for an empty string. #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is essentially a port of PR #69 to ROS 2 so that clang-tidy will stop complaining about it. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
|
Assuming this is approved and merged, I'll open up backport PRs for Dashing and Eloquent as well. |
|
CI for class loader, mostly making sure that Windows and Mac have no esoteric complaints about this
|
nuclearsandwich
approved these changes
Dec 19, 2019
clalancette
added a commit
that referenced
this pull request
Dec 19, 2019
This is essentially a port of PR #69 to ROS 2 so that clang-tidy will stop complaining about it. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
clalancette
added a commit
that referenced
this pull request
Dec 19, 2019
This is essentially a port of PR #69 to ROS 2 so that clang-tidy will stop complaining about it. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
This was referenced Dec 19, 2019
clalancette
added a commit
that referenced
this pull request
Jan 8, 2020
This is essentially a port of PR #69 to ROS 2 so that clang-tidy will stop complaining about it. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
clalancette
added a commit
that referenced
this pull request
Jan 8, 2020
This is essentially a port of PR #69 to ROS 2 so that clang-tidy will stop complaining about it. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
mjcarroll
pushed a commit
that referenced
this pull request
Jan 10, 2020
This is essentially a port of PR #69 to ROS 2 so that clang-tidy will stop complaining about it. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
mjcarroll
pushed a commit
that referenced
this pull request
Jan 10, 2020
This is essentially a port of PR #69 to ROS 2 so that clang-tidy will stop complaining about it. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is essentially a port of PR #69 to ROS 2 so that clang-tidy
will stop complaining about it.
Signed-off-by: Chris Lalancette clalancette@openrobotics.org