Poco detection is too confident when seeing /usr/include/Foundation #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That folder is also provided by gnustep-base. Ubuntu encapsulates the gnustep headers in a GNUstep folder, however the project itself installs to /usr/include/Foundation and other linux distributions(Archlinux, Gentoo, Lunar-Linux, ...) respect this.
|
+1 |
|
Relying on a arbitrary file like AbstractCache.h looks a bit weird. Couldn't we either just check for existence of the folder |
|
Relying on the existence of the base folder is even more weird in my opinion. I just used the same criterion as used above in line 103 in both files. I'll change the pull request accordingly... |
SharedLibrary.h is included in the code, so it makes sense to check for this header specifically.
|
+1 |
mirzashah
pushed a commit
that referenced
this pull request
May 22, 2013
Poco detection is too confident when seeing /usr/include/Foundation
severin-lemaignan
pushed a commit
to severin-lemaignan/robotpkg
that referenced
this pull request
Aug 18, 2014
Changes since 0.1.29: 0.3.0 (2014-06-25) ------------------ * Use system-provided console-bridge * Contributors: Esteve Fernandez 0.2.5 (2014-03-04) ------------------ * Changed format of debug messages so that rosconsole_bridge can correctly parse the prefix * Improved debug output 0.2.4 (2014-02-12) ------------------ * fix race condition with multi threaded library loading (`#16 <https://github.com/ros/class_loader/issues/16>`_) 0.2.3 (2013-08-21) ------------------ * fix missing class name in logWarn output 0.2.2 (2013-07-14) ------------------ * check for CATKIN_ENABLE_TESTING (`#10 <https://github.com/ros/class_loader/issues/10>`_) * fix find Poco to return full lib path (`#8 <https://github.com/ros/class_loader/issues/8>`_) * add missing runtime destination for library under Windows * add Boosst component system 0.2.1 (2013-06-06) ------------------ * improve check for Poco foundation and headers (`#7 <https://github.com/ros/class_loader/issues/7>`_) 0.2.0 (2013-03-13) ------------------ * use find_package for Poco/dl instead to make it work on other platforms * update Poco cmake file to include libdl on non-windows systems * No longer CATKIN_DEPEND on console_bridge Remove useless patches that have been fixed upstream
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That folder is also provided by gnustep-base. Ubuntu encapsulates the gnustep
headers in a GNUstep folder, however the project itself installs to
/usr/include/Foundation and other linux distributions(Archlinux, Gentoo,
Lunar-Linux, ...) respect this.