Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ARROW_LIST to visualization_msgs/Marker #135

Open
christian-rauch opened this issue Oct 18, 2018 · 3 comments
Open

add ARROW_LIST to visualization_msgs/Marker #135

christian-rauch opened this issue Oct 18, 2018 · 3 comments

Comments

@christian-rauch
Copy link

The visualization_msgs/Marker should add a type for lists of arrows.
The message definition already has types for lists for spheres, cubes and lines. The types appear inconsistent since spheres and cubes exist as single and list version, but the line only exist as list version and the arrow and the cylinder only exist as single version. Having all basic shapes as single and list version would be more consistent.

The closest to ARROW_LIST is LINE_LIST, but the line does not visualise the direction, i.e. the start and end point. The line is also just visualised as 2D rectangle with the normal oriented towards the camera view.

@tfoote
Copy link
Member

tfoote commented Oct 19, 2018

An arrow field support does sound like it would be valuable. To work toward this I'd suggest tat you put together a coordinated PR both here and to the rviz Marker display for a coordinated review.

@LemonPi
Copy link

LemonPi commented Jan 30, 2023

Any luck with this?

@rr-tom-noble
Copy link

rr-tom-noble commented May 5, 2023

Similar PR implemented for ROS1 here (adds ARROW_STRIP, more similar to LINE_STRIP in that the arrows are defined tip to tail):

#190
ros-visualization/rviz#1786

The suggestion was to implement for ROS2 first, then backport, so there's a corresponding set of PRs currently open:

ros2/common_interfaces#218
ros2/rviz#972

Latter PR is in progress as I'm waiting for answers from someone with more experience with rviz2 for help porting over some of the non-obvious ROS1->ROS2 changes. The repo seems less active compared to rviz1 in terms of getting a response. Slighlty frustrating as I could finish off the PRs in a day or so once I have those answers. Any help getting them resolved would be much appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants