Add copyright notice for testing file #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
dirk-thomas
reviewed
May 14, 2020
Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
|
@scpeters May I have you take a look on this? should be ready to merge. |
chapulina
approved these changes
May 15, 2020
chapulina
approved these changes
May 15, 2020
| /********************************************************************* | ||
| * Software License Agreement (BSD License) | ||
| * | ||
| * Copyright (c) 2020, Open Source Robotics Foundation, Inc. |
There was a problem hiding this comment.
I think this could be 2016 since it's when the file was created.
There was a problem hiding this comment.
I used 2020 because its current state reflects mostly the work done on the latest two commits made this year, but I can change it if someone else agrees with you.
scpeters
approved these changes
May 15, 2020
| /********************************************************************* | ||
| * Software License Agreement (BSD License) | ||
| * | ||
| * Copyright (c) 2020, Open Source Robotics Foundation, Inc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title says, this is to target Quality Level 1 for this library as defined in REP-2004. I wasn't sure who to tag in the copyright notice, so I'm open to change it accordingly.
As this library does not check automatically copyright notices, I added an extra line to the Quality Level document stating that new files will require having it.
Signed-off-by: Jorge Perez jjperez@ekumenlabs.com