Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various CMakeLists.txt fix to ease Debian integration. #8

Merged
merged 4 commits into from
Jul 3, 2013

Conversation

thomas-moulard
Copy link
Contributor

Dear console_bridge maintainers,
this pull request integrates all the changes required to produce a Debian package following
the Debian policy from the last release.

Technically speaking:

  • make sure CMake clean the files it generates
  • rely on GNUInstallDirs.cmake to make package deployment more flexible
  • fix distributed CMake macro and pkg-config file to reflect the changes.
  • specify the SOVERSION for the generated library (please be careful to update this
    number accordingly in the next releases).

isucan added a commit that referenced this pull request Jul 3, 2013
Various CMakeLists.txt fix to ease Debian integration.
@isucan isucan merged commit bad80c9 into ros:master Jul 3, 2013
@dirk-thomas
Copy link
Member

@isucan This should not be released as-is. The current state will not work with ROS. Please consider to make this an option but not the default. (Potentially the default could be selected based on the CMAKE_INSTALL_PREFIX?)

@isucan
Copy link
Contributor

isucan commented Oct 29, 2013

ok, will not release until we discuss more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants