Return the actual future from async_send_request #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recent changes to rclcpp in Rolling make it return a structure rather than just the future. In order to maintain this test, return the actual future. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
|
Gpr is definitely going to fail here, as this PR doesn't apply for Galactic. We'll need to make a new galactic-devel branch off of the current |
norro
approved these changes
Oct 18, 2021
I created the 'galactic' branch, and changed galactic over to using it in ros/rosdistro#31002 . We don't have good support for "removing" a test once it has been added to a PR, so that test is failing here. But future PRs won't even start a With that said, thanks for the review. Merging. |
wep21
pushed a commit
to wep21/diagnostics
that referenced
this pull request
Oct 30, 2021
Recent changes to rclcpp in Rolling make it return a structure rather than just the future. In order to maintain this test, return the actual future. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
wep21
pushed a commit
to wep21/diagnostics
that referenced
this pull request
Nov 1, 2021
Recent changes to rclcpp in Rolling make it return a structure rather than just the future. In order to maintain this test, return the actual future. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
wep21
pushed a commit
to wep21/diagnostics
that referenced
this pull request
Nov 1, 2021
Recent changes to rclcpp in Rolling make it return a structure rather than just the future. In order to maintain this test, return the actual future. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent changes to rclcpp in Rolling make it return a structure
rather than just the future. In order to maintain this test,
return the actual future.
Signed-off-by: Chris Lalancette clalancette@openrobotics.org