Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing pep257 problems introduced by #334 #384

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Fixing pep257 problems introduced by #334 #384

merged 1 commit into from
Jul 17, 2024

Conversation

ct2034
Copy link
Collaborator

@ct2034 ct2034 commented Jul 17, 2024

fixes

./diagnostic_common_diagnostics/diagnostic_common_diagnostics/hd_monitor.py:67 in public class `HDMonitor`: D213: Multi-line docstring summary should start at the second line
./diagnostic_common_diagnostics/diagnostic_common_diagnostics/hd_monitor.py:93 in public method `callback_config`: D213: Multi-line docstring summary should start at the second line
./diagnostic_common_diagnostics/diagnostic_common_diagnostics/hd_monitor.py:111 in public method `check_disk_usage`: D213: Multi-line docstring summary should start at the second line

@ct2034
fixing pep257 problems introduced by #334
1405877 
Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
@ct2034 ct2034 merged commit b504059 into ros2 Jul 17, 2024
10 of 11 checks passed
@ct2034 ct2034 deleted the fix/docstrings_hd_monitor branch July 17, 2024 12:51
ct2034 added a commit to ct2034/diagnostics that referenced this pull request Jul 17, 2024
@ct2034
fixing pep257 problems introduced by ros#334 (ros#384)
2b25e4b 
Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
ct2034 added a commit to ct2034/diagnostics that referenced this pull request Jul 17, 2024
@ct2034
fixing pep257 problems introduced by ros#334 (ros#384)
e496d1a 
Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
ct2034 added a commit to ct2034/diagnostics that referenced this pull request Jul 17, 2024
@ct2034
fixing pep257 problems introduced by ros#334 (ros#384)
3974f2a 
Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
ct2034 added a commit that referenced this pull request Jul 17, 2024
@ct2034 @limaanto
[ros2-iron] Port hd_monitor to ROS2 (#334) (#382)
605b72b 
* Port hd_monitor to ROS2 (#334)

* Port hd_monitor.py
* Adapt documentation and CMakeList to new hd_monitor.py
* Fix execution flag of hd_monitor
* Add launch test for hd_monitor
* Implement low and crit parameters in hd_monitor
* Improve hd_monitor code quality

(cherry picked from commit 05a9645)

* fixing pep257 problems introduced by #334 (#384)

Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>

---------

Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
Co-authored-by: Antoine Lima <7421319+limaanto@users.noreply.github.com>
ct2034 added a commit that referenced this pull request Jul 17, 2024
@ct2034 @limaanto
[ros2-humble] Port hd_monitor to ROS2 (#334) (#381)
fe98a48 
* Port hd_monitor to ROS2 (#334)

* Port hd_monitor.py
* Adapt documentation and CMakeList to new hd_monitor.py
* Fix execution flag of hd_monitor
* Add launch test for hd_monitor
* Implement low and crit parameters in hd_monitor
* Improve hd_monitor code quality

(cherry picked from commit 05a9645)

* fixing pep257 problems introduced by #334 (#384)

Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>

---------

Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
Co-authored-by: Antoine Lima <7421319+limaanto@users.noreply.github.com>
ct2034 added a commit to ct2034/diagnostics that referenced this pull request Jul 22, 2024
@ct2034
fixing pep257 problems introduced by ros#334 (ros#384)
6b8f6a7 
Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
(cherry picked from commit b504059)
@ct2034
Copy link
Collaborator Author

ct2034 commented Jul 22, 2024

💔 Some backports could not be created

Status Branch Result
❌ ros2-humble Cherrypick failed because the selected commit (b504059) is empty. Did you already backport this commit?
❌ ros2-iron Cherrypick failed because the selected commit (b504059) is empty. Did you already backport this commit?
✅ ros2-jazzy

Manual backport

To create the backport manually run:

backport --pr 384

Questions ?

Please refer to the Backport tool documentation

@ct2034 ct2034 mentioned this pull request Jul 22, 2024
Merged
ct2034 added a commit that referenced this pull request Jul 22, 2024
@ct2034
fixing pep257 problems introduced by #334 (#384) (#392)
f92c157 
Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
(cherry picked from commit b504059)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ct2034