feat(common_diagnostics): Added GPU monitor #70
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fix for the failing check: PR |
tfoote
requested changes
Dec 12, 2017
There was a problem hiding this comment.
Note that this dependency is pip only which means that this would not be releasable into debian packages anymore which is a requirement for a package at this low of a level.
This might make more sense as a standalone package available for people using nvidia GPUs to install from source instead of being in the default diagnostics repository since this is only useful for nvidia users as well.
|
@tfoote Thank you for your advice. Now that I understand the limitations I've decided to create a standalone package. I will make it available as soon as it is finished. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a GPU monitor that provides the GPU and memory load percentages and the percentage of used memory. Warning thresholds for each value may be specified.