Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows][melodic] Fix _CUSTOM_PYTHONPATH_ENV on Windows build #134

Merged
merged 1 commit into from
Mar 6, 2019
Merged

[Windows][melodic] Fix _CUSTOM_PYTHONPATH_ENV on Windows build #134

merged 1 commit into from
Mar 6, 2019

Conversation

seanyen
Copy link
Contributor

@seanyen seanyen commented Feb 20, 2019

On Windows, even if the project calling generate_dynamic_reconfigure_options() doesn't have ${CATKIN_GLOBAL_PYTHON_DESTINATION}, it still needs to set _CUSTOM_PYTHONPATH_ENV to something like python, because Windows doesn't have shebang support and cannot run the <generated>.cfg directly.

(This change is verified in https://aka.ms/ros project.)

@seanyen
Copy link
Contributor Author

seanyen commented Feb 20, 2019

To add more information: This problem manifests when nodelet_topic_tools builds, where it doesn't call catkin_python_setup() and doesn't have ${CATKIN_GLOBAL_PYTHON_DESTINATION}.

@seanyen
Copy link
Contributor Author

seanyen commented Mar 4, 2019

@mikaelarguedas hope I am pinging the correct person. This is another Windows specific issue found in https://aka.ms/ros. I'd love any feedbacks and see if this can be merged to the upstream. Thanks!

@mjcarroll
Copy link
Member

@seanyen-msft I'm the maintainer, I'll take a look. Thanks for the patch.

@mjcarroll mjcarroll merged commit 0556c0a into ros:melodic-devel Mar 6, 2019
@seanyen
Copy link
Contributor Author

seanyen commented Mar 6, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants