Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set queue_size=1 on publishers #35

Closed
ibaranov-cp opened this issue Sep 15, 2014 · 3 comments
Closed

set queue_size=1 on publishers #35

ibaranov-cp opened this issue Sep 15, 2014 · 3 comments

Comments

@ibaranov-cp
Copy link

hey,

In hydro, queue size is an optional parameter, but is suggested to be used.
I suggest size of 1, but anything would do.

Specifically, lines:
self.descr_topic = rospy.Publisher('~parameter_descriptions', ConfigDescrMsg, latch=True, queue_size=1)

and

self.update_topic = rospy.Publisher('~parameter_updates', ConfigMsg, latch=True, queue_size=1 )

in

/opt/ros/indigo/lib/python2.7/dist-packages/dynamic_reconfigure/server.py

@BennyRe
Copy link

BennyRe commented Sep 24, 2014

+1

First I thought a queue size of 1 is a bit unsafe but after looking at the code nothing speaks against it.

@dirk-thomas
Copy link
Member

WIth a queue_size of 1 when the dynamic reconfigure Server is going to send multiple parameter updates shortly after each other the chances are very high that only the latest publish call will happen. The previous ones will just vanish / be overwritten in the queue before sending. I don't think that this is desired and would therefore not recommend to choose a queue_size of 1.

@ibaranov-cp
Copy link
Author

Perhaps a reasonable middle ground then? Say 10?

@esteve esteve closed this as completed in beddb60 Dec 15, 2014
esteve added a commit that referenced this issue Dec 15, 2014
fixes #35 by setting queue_size to 10 for publishers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants