-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port package to ROS 2 #16
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor things; once those are addressed, I'm happy to merge this.
CMakeLists.txt
Outdated
project(eigen_stl_containers) | ||
|
||
find_package(catkin REQUIRED) | ||
if(NOT WIN32) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This block is redundant (and actually somewhat in opposition to):
if(NOT CMAKE_CXX_STANDARD)
set(CMAKE_CXX_STANDARD 14)
endif()
below, so just remove it.
CMakeLists.txt
Outdated
add_compile_options(-Wall -Wextra -Wpedantic) | ||
endif() | ||
|
||
find_package(ament_cmake REQUIRED) | ||
find_package(Eigen3 QUIET) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can just make this:
find_package(Eigen3 REQUIRED)
And get rid of all of the backwards-compatibility stuff; this will never go onto older Ubuntu versions.
<build_depend>eigen</build_depend> | ||
|
||
<build_export_depend>eigen</build_export_depend> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing:
<export>
<build_type>ament_cmake</build_type>
</export>
Comments made at ros#16
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
@vmayoral I did a few more fixups in a611d8a . In particular:
With that, I'm happy with this, and I'm going to merge. Thanks for the contribution! |
Thanks a lot for the fixes @clalancette! Happy to contribute. |
No description provided.