fix generating duplicate include dirs for multiple add_message_files() invocations #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirk-thomas
added a commit
that referenced
this pull request
Jun 5, 2013
fix generating duplicate include dirs for multiple add_message_files() invocations
PierrickKoch
pushed a commit
to PierrickKoch/robotpkg
that referenced
this pull request
Feb 21, 2014
Changes since 0.3.10: 0.4.20 (2013-06-18) ------------------- * generate pkg config extra files containing variables which list all message and service files (`#28 <https://github.com/ros/genmsg/issues/28>`_) 0.4.19 (2013-06-06) ------------------- * improve error message for missing message dependencies (`#1 <https://github.com/ros/genmsg/issues/1>`_) * fix generating duplicate include dirs for multiple add_message_files() invocations which broke generated lisp messages (`#27 <https://github.com/ros/genmsg/issues/27>`_) 0.4.18 (2013-03-08) ------------------- * fix handling spaces in folder names (`ros/catkin#375 <https://github.com/ros/catkin/issues/375>`_) * add targets with _generate_messages_LANG suffix (`#20 <https://github.com/ros/genmsg/issues/20>`_) * pass all message generation target to EXPORTED_TARGETS (`#26 <https://github.com/ros/genmsg/issues/26>`_) * improve error messages (`#22 <https://github.com/ros/genmsg/issues/22>`_) 0.4.17 (2013-01-19) ------------------- * fix bug using ARGV in list(FIND) directly (`#18 <https://github.com/ros/genmsg/issues/18>`_) 0.4.16 (2013-01-13) ------------------- * hide transitive message dependencies and pull them in automatically (`#15 <https://github.com/ros/genmsg/issues/15>`_) 0.4.15 (2012-12-21) ------------------- * first public release for Groovy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Duplicate search paths generate faulty .asd files from message definitions. It is most visible for actions since they call add_message_files() multiple times which leads to the duplicate include dirs.
The problem was brought up on ros-users in this mail thread:
https://code.ros.org/lurker/thread/20130605.125757.7e5ce9d5.en.html
(request/feedback/reply messages get defined multiple times, i.e. breaking ASDF loading)