Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
1 parent
18620c1
commit 085e265
Showing
1 changed file
with
4 additions
and
18 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
085e265
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi guys! We know that in ROS Kinetic you officially only support Python 2.x. But much of your code is actually compatible to be run under Python 3.x - We appreciate all your hard work and I know this is actually our fault since we relied on something that is not to be relied on by the specs but it would be nice if you didn't break any such compatibility with "updates" anymore in the future. The update with this change broke our rospy dependent code which actually ran fine before under Python 3.5...
085e265
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From you comment I couldn't extract yet what the problem is except that something broke for you with Python 3.5. Can you please describe what exactly changed behavior and broke compatibility.
085e265
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is rather simple: The "cmp" function doesn't exist anymore in Python 3 (see https://docs.python.org/3.0/whatsnew/3.0.html)
085e265
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for clarifying. Since we don't run any tests with Python 3 that went in without being notices. I have created #71 to address this (as well as a couple of other issues). Can you please confirm that the branch makes it work for you with Python 3 again.
085e265
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm rather impressed by the quick response, thank you! I didn't test the referenced branch but chose the quicker way of testing the new rostime.py by copying it into my current installation: I can confirm that it resolves the Python 3 issue.
085e265
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for testing the change. I guess it is soon time for a new genpy release then... 😞
085e265
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@islers: How are you ending up in a state where
cmp
even gets executed?085e265
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well I can tell you where and why, but I didn't debug the complete process stack to tell you how.
085e265
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't worry about it, this was resolved in another comment thread