Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deserialize bytes in Python3 #10

Merged
merged 1 commit into from
May 31, 2013
Merged

Fix deserialize bytes in Python3 #10

merged 1 commit into from
May 31, 2013

Conversation

PierrickKoch
Copy link
Contributor

See #9 and morse-simulator/morse#218

data in Image and PointCloud2 should be kept as bytes, not decoded as utf-8.

Tested with:

./scripts/genmsg_py.py -p sensor_msgs -Istd_msgs:`rospack find std_msgs`/msg -Isensor_msgs:`rospack find sensor_msgs`/msg -o gen `rospack find sensor_msgs`/msg/Image.msg

diff -ur1 /opt/ros/fuerte/lib/python2.7/dist-packages/sensor_msgs/msg/_Image.py gen/_Image.py

@tfoote
Copy link
Member

tfoote commented May 31, 2013

+1

@dirk-thomas
Copy link
Member

Sorry for not spotting this pull request earlier. Merging...

dirk-thomas added a commit that referenced this pull request May 31, 2013
@dirk-thomas
Merge pull request #10 from pierriko/groovy-devel
11e483b 
Fix deserialize bytes in Python3
@dirk-thomas dirk-thomas merged commit 11e483b into ros:groovy-devel May 31, 2013
dirk-thomas added a commit that referenced this pull request Jun 24, 2013
@dirk-thomas
update tests to match #10
1ad08eb
PierrickKoch pushed a commit to PierrickKoch/robotpkg that referenced this pull request Feb 21, 2014
[lang/ros-genpy] Update to 0.4.12
c7cdac5 
Changes since 0.3.7:

0.4.12 (2013-06-18)
-------------------
* fix deserialize bytes in Python3
  (`#10 <https://github.com/ros/genpy/issues/10>`_)

0.4.11 (2013-03-08)
-------------------
* fix handling spaces in folder names
  (`ros/catkin#375 <https://github.com/ros/catkin/issues/375>`_)

0.4.10 (2012-12-21)
-------------------
* first public release for Groovy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@PierrickKoch @tfoote @dirk-thomas