Adding new argument to generate_dynamic: tmp_dir_path and tmp_file_name #125
Conversation
src/genpy/dynamic.py
Outdated
| tmp_file.file.close() | ||
| if tmp_dir_path: | ||
| # Create a temporary directory with specified path | ||
| tmp_dir = os.mkdir(tmp_dir_path) |
There was a problem hiding this comment.
This should probably handle the case that the directory already exists.
There was a problem hiding this comment.
My thought process was that if an output_file was given, it would overwrite the file if it exists. However, if the file does not exist, it would create a file at the given output_file path.
There was a problem hiding this comment.
By just removing this line it doesn't handle the case anymore where the directory doesn't exist.
There was a problem hiding this comment.
By just removing this line it doesn't handle the case anymore where the directory doesn't exist.
@jimwelagu This comment is still pending.
|
@jimwelagu Friendly ping. |
Made some changes per your requests. |
|
@dirk-thomas Friendly ping. |
|
@jimwelagu Are you still interested in this PR and willing to address the above pending feedback? |
For Issue: #124