Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copy transform before altering it in do_transform_vector3 [issue 233] #235

Merged
merged 1 commit into from May 10, 2017
Merged

Copy transform before altering it in do_transform_vector3 [issue 233] #235

merged 1 commit into from May 10, 2017

Conversation

swagner91
Copy link
Contributor

@swagner91 swagner91 commented May 10, 2017 •
edited

Fixes #233, where a transform passed to do_transform_vector3 was changes inside the function and made useless for later transforms.

tfoote
tfoote approved these changes May 10, 2017
View reviewed changes
Copy link
Member

@tfoote tfoote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks this looks good.

@tfoote
Copy link
Member

tfoote commented May 10, 2017

@ros-pull-request-builder retest this please

@tfoote tfoote merged commit 54d659c into ros:indigo-devel May 10, 2017
@swagner91 swagner91 deleted the iss233 branch May 11, 2017 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tfoote tfoote tfoote approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@swagner91 @tfoote