Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated policy warning #67

Merged
merged 1 commit into from
Sep 28, 2021
Merged

Remove deprecated policy warning #67

merged 1 commit into from
Sep 28, 2021

Conversation

hello-binit
Copy link

On ROS2 Galactic, Ubuntu 20.04, and Python3.8,

$ ros2 run joint_state_publisher joint_state_publisher --ros-args --param zeros.joint_hey:=1.0

[INFO] [1632341480.045667155] [joint_state_publisher]: Waiting for robot_description to be published on the robot_description topic...
/opt/ros/galactic/lib/python3.8/site-packages/rclpy/qos.py:307: UserWarning: DurabilityPolicy.RMW_QOS_POLICY_DURABILITY_TRANSIENT_LOCAL is deprecated. Use DurabilityPolicy.TRANSIENT_LOCAL instead.
  warnings.warn(

This PR removes the UserWarning by using TRANSIENT_LOCAL instead.

@sloretz sloretz changed the base branch from foxy to ros2 September 23, 2021 21:13
@sloretz sloretz changed the base branch from ros2 to foxy September 23, 2021 21:15
@sloretz sloretz changed the base branch from foxy to ros2 September 23, 2021 21:34
@sloretz
Copy link
Contributor

sloretz commented Sep 23, 2021

@ros-pull-request-builder retest this please

@sloretz sloretz mentioned this pull request Sep 23, 2021
Open
clalancette
clalancette approved these changes Sep 28, 2021
View reviewed changes
Copy link
Collaborator

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though the CI is failing, it has nothing to do with this PR. This is clearly the right thing to do on Galactic and Rolling, and I've verified locally that it works. So I'm going to go ahead and merge this, as well as backport it to the galactic branch. Thanks for the PR!

@clalancette clalancette merged commit 72aec78 into ros:ros2 Sep 28, 2021
clalancette pushed a commit that referenced this pull request Sep 28, 2021
@hello-binit @clalancette
Remove deprecated policy warning (#67)
e0c2ca2
clalancette added a commit that referenced this pull request Sep 28, 2021
@clalancette @hello-binit
Remove deprecated policy warning (#67) (#73)
c31f4bf 
Co-authored-by: Binit Shah <bshah@hello-robot.com>
@hello-binit hello-binit deleted the bugfix/deprecated_policy branch September 28, 2021 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hello-binit @sloretz @clalancette