Fix the mimic_cycle test to always succeed. #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In particular, we weren't keeping the process alive, and we weren't waiting for the process to finish before checking the output. Because of that, the test only worked if the launched process happened to complete before the checks fired. Instead, mark things as keep_alive, and make sure to have a concurrent test that waits for the process to finish before doing checks. This makes the test always finish. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
hidmic
approved these changes
Oct 22, 2021
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular, we weren't keeping the process alive, and we
weren't waiting for the process to finish before checking the
output. Because of that, the test only worked if the launched
process happened to complete before the checks fired.
Instead, mark things as keep_alive, and make sure to have a
concurrent test that waits for the process to finish before
doing checks. This makes the test always finish.
Signed-off-by: Chris Lalancette clalancette@openrobotics.org
This is all based on the conversation in ros2/launch#534 .