Use underscores in setup.cfg. #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the more standards-oriented way to do things (and avoids a warning in newer setuptools). Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
sloretz
approved these changes
Mar 15, 2022
|
In the past I relied on the Rpr job to go green here for CI. Since that is not working at the moment, I'm just going to assert that I was able to build and run the tests on this locally and they all pass. This doesn't guarantee that it will run on the buildfarm, but given the simple nature of this PR I think that is sufficient. I'm going to go ahead and merge this, thanks for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the more standards-oriented way to do things (and
avoids a warning in newer setuptools).
Signed-off-by: Chris Lalancette clalancette@openrobotics.org