Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only update one joint slider on value changed. #11

Merged
merged 2 commits into from
Jan 16, 2019
Merged

Only update one joint slider on value changed. #11

merged 2 commits into from
Jan 16, 2019

Commits on Jul 10, 2018

  1. Only update one joint slider on value changed. 

    This should fix the issue raised in
#5.  The
basic problem is that update_sliders() changes the values
of the sliders, which causes the "onValueChanged" signal
to be emitted for each slider.  The problem is that both
update_sliders() and onValueChanged() iterate over the
entire list of joints, so onValueChanged() is re-evaluating
all sliders during each setValue() in the update_sliders()
loop.  To avoid this problem, change onValueChanged() to
only operate on the field that actually changed, which is
accomplished with a lambda.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
    @clalancette
    clalancette committed Jul 10, 2018
    Configuration menu
    Copy the full SHA
    acc691b View commit details
    Browse the repository at this point in the history

  2. Remove debugging print statement. 

    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
    @clalancette
    clalancette committed Jul 10, 2018
    Configuration menu
    Copy the full SHA
    c8ad977 View commit details
    Browse the repository at this point in the history