Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install includes to include/${PROJECT_NAME} and more modern CMake. #61

Merged
merged 1 commit into from
Jan 10, 2022
Merged

Install includes to include/${PROJECT_NAME} and more modern CMake. #61

merged 1 commit into from
Jan 10, 2022

Conversation

sloretz
Copy link
Contributor

@sloretz sloretz commented Jan 5, 2022

Part of ros2/ros2#1150

This installs includes to include/${PROJECT_NAME} to mitigate include directory search order issues when overriding packages in desktop.

Part of ament/ament_cmake#365

This removes ament_export_libraries and ament_export_include_directories as they're redundant with the exported CMake targets.

Part of ament/ament_cmake#292

This replaces ament_target_dependencies() calls with target_link_libraries().

Also fixes #58

@sloretz
Install includes to include/ and misc CMake fixes
4fb0a33 
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
@sloretz sloretz self-assigned this Jan 5, 2022
@sloretz sloretz mentioned this pull request Jan 5, 2022
Merged
clalancette
clalancette approved these changes Jan 6, 2022
View reviewed changes
Copy link
Collaborator

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable to me with green CI.

@sloretz
Copy link
Contributor Author

sloretz commented Jan 10, 2022

CI (repos file build: --packages-above-and-dependencies kdl_parser test: --packages-above kdl_parser)

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@sloretz sloretz merged commit 2ed0c91 into ros2 Jan 10, 2022
@sloretz sloretz deleted the sloretz__easy_idso_part1 branch January 10, 2022 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

Assignees

@sloretz sloretz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sloretz @clalancette