Use the rcutils logger instead of printf #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
sloretz
reviewed
Jun 17, 2022
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
sloretz
approved these changes
Jun 17, 2022
|
CI:
|
schornakj
pushed a commit
to schornakj/kdl_parser
that referenced
this pull request
Dec 4, 2022
* logging feature: fprintf replaced by rcutils_log Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> Co-authored-by: yura <yura@getsomatic.com>
clalancette
pushed a commit
that referenced
this pull request
Jan 2, 2023
* Use the rcutils logger instead of printf (#65) Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> Signed-off-by: Joe Schornak <joe.schornak@gmail.com> Co-authored-by: yura <yura@getsomatic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rehash of #52, which has been closed because of non-responsiveness of the original submitter. That said, this is a valuable change to have, so here is that change plus some additional changes from review.
@SammyRamone FYI.