-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add in a LICENSE file. #66
Conversation
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
The license text references a copyright holder, and I've typically seen the 3-clause BSD license include the copyright lines at the beginning. Is there a particular reason to omit it here? |
Also enable the copyright ament lint checking. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
You bring up a good point, which caused me to examine a couple of different things. First of all, the copyright checking in this package was disabled. That means we didn't even know if this file conformed to the LICENSE style as laid out in The second thing I did was to check out what other BSD-style LICENSE files around our codebase looked like. To summarize, I found the following:
Apparently our linting accepts all 3 styles, so it is not a problem for linting. As for what it should look like, I actually think style 2 is the best, as it is a LICENSE file, not a copyright notice. That said, it looks like the bulk of what we have does include both the "BSD License" and the copyright holders, so I'll switch this one to go with the majority there. |
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Signed-off-by: Chris Lalancette clalancette@openrobotics.org