show warning in every 10 seconds when manager is not found #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knorth55
changed the title
gbiggs
reviewed
Jan 6, 2022
Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net>
gbiggs
approved these changes
Jan 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
current
noetic-develbranch only showsros::ServiceClientwaitForInstanceat the beginning,which is flushed quickly when we launch a lot of nodes.
When we set wrong manager name, it is difficult to recognize the manager name mistake because
ros::ServiceClientonly showswaitForInstancemessage only at the beginning.This PR change to show the warning message every 10 seconds.
The following output is the example of warning message in every 10 seconds.
at the end I ran nodelet_manager manually, and nodelets are correctly loaded.