-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add std::unique_ptr API #42
Conversation
Thanks for the follow up PR, the change looks good for me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I skimmed the changes
tested locally on both kinetic and indigo without problem |
Thanks for the quick review and merge :) |
Released on kinetic and will release on earlier distros once we're sure that no unexpected behaviour emerges |
It would be great to have this available in indigo too! So +1 to backport this change to indigo and jade |
This follows ros/class_loader#38 and adds the API to
pluinglib
as well. That means it requiresindigo-devel
fromclass_loader
to build, which is probably not available for the automated tests. I'm not sure what the best solution is for that. It would be nice to release this API addition together withclass_loader
.Points to note for the review:
ASSERT_THROW
for readability.ASSERT_THROW
checks the exception type, so old behaviour of the test is maintained.