-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python3 compatibility #10
Conversation
As urlgrabber is not supported for Python 3 replace it with either the built-in urllib (Python 2) or urllib2 (Python 3)
Please take a look @jacquelinekay @mikepurvis |
Looks sane to me. Might make sense to add a travis config for ensuring coverage of py2 and py3, but that's up to the OSRF maintainers. |
@jacquelinekay Any chances on getting this in? |
I think it's @isucan maintaining this now. This should definitely merge in preparation for the Lunar release. |
I wrote the Python one, so I felt comfortable merging this in. I know that @clalancette and @sloretz were taking over some of @jacquelinekay 's stuff (ros/urdf_parser_py#12). Perhaps this is another candidate. |
Yeah, we did take over some of @jacquelinekay 's stuff, but since this one seemed to be maintained by Ioan (Jackie was never listed in the package.xml), we haven't looked at it at all. |
@clalancette if you look at the commits she was definitely maintaining this one too, Jackie probably just didn't update the It will be blocking the release of |
Got it. Shane and I have now taken maintainership of it. |
urlgrabber is not available for python3 (at least not on OSX) so I replaced the urlgrabber usage in the python version of resource_retriever with the python built in urllib/urllib2.
In addition I replaced the home baked rospack_find by rospkg and added unit tests for the python api.