Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libcurl_vendor] convert to ament and setup env hooks for library paths #14

Merged
merged 2 commits into from
Jan 23, 2018

Conversation

wjwwood
Copy link
Member

@wjwwood wjwwood commented Jan 12, 2018

In support of ros2/rviz#175. Without this change the library installed to opt/libcurl_vendor is not found at runtime.

@wjwwood wjwwood self-assigned this Jan 12, 2018
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable enough to me.

@sloretz sloretz mentioned this pull request Jan 16, 2018
@wjwwood wjwwood merged commit 48193d3 into ros2 Jan 23, 2018
wjwwood added a commit that referenced this pull request Feb 7, 2018
…hs (#14) (#18)

* [libcurl_vendor] convert to ament and setup env hooks for library paths

* log build of libcurl to file
nuclearsandwich pushed a commit to ros/rosdistro that referenced this pull request Apr 19, 2019
…20969)

Increasing version of package(s) in repository `resource_retriever` to `2.1.0-1`:

- upstream repository: https://github.com/ros/resource_retriever.git
- release repository: https://github.com/ros2-gbp/resource_retriever-release.git
- distro file: `dashing/distribution.yaml`
- bloom version: `0.8.0`
- previous version for package: `null`

## libcurl_vendor

```
* depend on curl (mapping to curl, libcurl4-openssl-dev) for packaging (#25 <ros/resource_retriever#25>)
* add missing dependency on pkg-config (#19 <ros/resource_retriever#19>)
* [libcurl_vendor] convert to ament and setup env hooks for library paths (#14 <ros/resource_retriever#14>)
* Contributors: Dirk Thomas, Mikael Arguedas, William Woodall
```

## resource_retriever

```
* Make sure to export the include directory for resource_retriever. (#22 <ros/resource_retriever#22>)
* Contributors: Chris Lalancette
```
andre-rosa pushed a commit to andre-rosa/rosdistro that referenced this pull request May 3, 2019
…os#20969)

Increasing version of package(s) in repository `resource_retriever` to `2.1.0-1`:

- upstream repository: https://github.com/ros/resource_retriever.git
- release repository: https://github.com/ros2-gbp/resource_retriever-release.git
- distro file: `dashing/distribution.yaml`
- bloom version: `0.8.0`
- previous version for package: `null`

## libcurl_vendor

```
* depend on curl (mapping to curl, libcurl4-openssl-dev) for packaging (ros#25 <ros/resource_retriever#25>)
* add missing dependency on pkg-config (ros#19 <ros/resource_retriever#19>)
* [libcurl_vendor] convert to ament and setup env hooks for library paths (ros#14 <ros/resource_retriever#14>)
* Contributors: Dirk Thomas, Mikael Arguedas, William Woodall
```

## resource_retriever

```
* Make sure to export the include directory for resource_retriever. (ros#22 <ros/resource_retriever#22>)
* Contributors: Chris Lalancette
```
@clalancette clalancette deleted the library_paths branch September 11, 2019 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants