Make sure to export the include directory for resource_retriever. #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, it can't properly be used as a library. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
|
|
Can you please export the package libraries, interfaces and the include directories before the dependencies? (c.f. ongoing set of PRs for fixing the order of exports) |
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Sure, the latest commit moves it around to the same order as some of the other PRs. |
sloretz
approved these changes
Mar 13, 2018
|
Thanks for the reviews. I'm fairly certain that the CI failures are unrelated to this PR (the macOS ones look like a bug in rclcpp, while the Windows one looks like a known issue: ros2/build_farmer#86). Therefore, I'm going to merge this. |
nuclearsandwich
pushed a commit
to ros/rosdistro
that referenced
this pull request
Apr 19, 2019
…20969) Increasing version of package(s) in repository `resource_retriever` to `2.1.0-1`: - upstream repository: https://github.com/ros/resource_retriever.git - release repository: https://github.com/ros2-gbp/resource_retriever-release.git - distro file: `dashing/distribution.yaml` - bloom version: `0.8.0` - previous version for package: `null` ## libcurl_vendor ``` * depend on curl (mapping to curl, libcurl4-openssl-dev) for packaging (#25 <ros/resource_retriever#25>) * add missing dependency on pkg-config (#19 <ros/resource_retriever#19>) * [libcurl_vendor] convert to ament and setup env hooks for library paths (#14 <ros/resource_retriever#14>) * Contributors: Dirk Thomas, Mikael Arguedas, William Woodall ``` ## resource_retriever ``` * Make sure to export the include directory for resource_retriever. (#22 <ros/resource_retriever#22>) * Contributors: Chris Lalancette ```
andre-rosa
pushed a commit
to andre-rosa/rosdistro
that referenced
this pull request
May 3, 2019
…os#20969) Increasing version of package(s) in repository `resource_retriever` to `2.1.0-1`: - upstream repository: https://github.com/ros/resource_retriever.git - release repository: https://github.com/ros2-gbp/resource_retriever-release.git - distro file: `dashing/distribution.yaml` - bloom version: `0.8.0` - previous version for package: `null` ## libcurl_vendor ``` * depend on curl (mapping to curl, libcurl4-openssl-dev) for packaging (ros#25 <ros/resource_retriever#25>) * add missing dependency on pkg-config (ros#19 <ros/resource_retriever#19>) * [libcurl_vendor] convert to ament and setup env hooks for library paths (ros#14 <ros/resource_retriever#14>) * Contributors: Dirk Thomas, Mikael Arguedas, William Woodall ``` ## resource_retriever ``` * Make sure to export the include directory for resource_retriever. (ros#22 <ros/resource_retriever#22>) * Contributors: Chris Lalancette ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, it can't properly be used as a library.
fixes #21
Signed-off-by: Chris Lalancette clalancette@openrobotics.org