Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export TARGETS in libcurl_vendor #46

Merged
merged 1 commit into from
Jun 4, 2020

Conversation

dirk-thomas
Copy link
Member

Necessary to make downstream packages like rviz_common which already use modern CMake targets relocatable.

See ros2/rviz#554 and ros2/rviz#556.

Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
@dirk-thomas
Copy link
Member Author

dirk-thomas commented Jun 2, 2020

CI builds building all with FastRTPS but only testing the touched package (since this doesn't affect runtime):

Copy link

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending CI

@dirk-thomas dirk-thomas merged commit eb1eab2 into ros2 Jun 4, 2020
@dirk-thomas dirk-thomas deleted the dirk-thomas/export-libcurl-target branch June 4, 2020 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants