Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add .hpp header and deprecate .h #51

Merged
merged 2 commits into from
Aug 7, 2020
Merged

Add .hpp header and deprecate .h #51

merged 2 commits into from
Aug 7, 2020

Conversation

sloretz
Copy link
Contributor

@sloretz sloretz commented Aug 6, 2020

This PR is two commits and should be rebase and merged to capture the moved file in history. The first commit renames retriever.h to retriever.hpp with no other changes. The second commit creates a new retriever.h that warns it is deprecated and includes retriever.hpp as well as making the code changes to use retriever.hpp.

@sloretz
retriever.h -> retriever.hpp
2f1b9a1 
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
@sloretz
Use retriever.hpp and redirect from retriever.h
9c64e60 
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
@sloretz sloretz self-assigned this Aug 6, 2020
@sloretz sloretz mentioned this pull request Aug 6, 2020
Closed
@sloretz
Copy link
Contributor Author

sloretz commented Aug 6, 2020

CI linux build: --packages-above resource_retriever test: --packages-select resource_retriever to look for warnings downstream: Build Status

clalancette
clalancette reviewed Aug 7, 2020
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor question, and it looks like CI failed. Once those are fixed this is fine with me, thanks for doing this.

resource_retriever/include/resource_retriever/retriever.h Show resolved Hide resolved
@sloretz
Copy link
Contributor Author

sloretz commented Aug 7, 2020

One minor question, and it looks like CI failed.

Oops, I used the wrong build args. New build --packages-above-and-dependencies resource_retriever test --packages-select resource_retriever

  • Linux Build Status
  • Windows Build Status

@sloretz sloretz mentioned this pull request Aug 7, 2020
Merged
@sloretz
Copy link
Contributor Author

sloretz commented Aug 7, 2020 •
edited
Loading

CI (build: --packages-above-and-dependencies resource_retriever test: --packages-select resource_retriever rviz_common rviz_default_plugins rviz_rendering rviz_rendering_tests)

  • Linux Build Status
    • java traceback, rebuilding: Build Status
  • Linux-aarch64 Build Status
    • java traceback, rebuilding: Build Status
      • java traceback, rebuilding: Build Status
  • macOS Build Status
  • Windows Build Status

@sloretz sloretz merged commit 854c836 into ros2 Aug 7, 2020
@sloretz sloretz deleted the sloretz/deprecate_h_for_hpp branch August 7, 2020 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

Assignees

@sloretz sloretz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sloretz @clalancette