Throw exception if package name is empty #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, ament_index_cpp will throw a std::runtime_error. Throwing an exception from resource_retriever instead makes for a more useful error message. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
ahcorde
approved these changes
Oct 15, 2020
clalancette
approved these changes
Oct 15, 2020
|
|
I think this would be good to backport to Foxy (and maybe other distros). For context, this fixes a crash in RViz when loading meshes. It is only expecting exceptions of type |
jacobperron
added a commit
that referenced
this pull request
Oct 16, 2020
Otherwise, ament_index_cpp will throw a std::runtime_error. Throwing an exception from resource_retriever instead makes for a more useful error message. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
jacobperron
added a commit
that referenced
this pull request
Oct 16, 2020
Otherwise, ament_index_cpp will throw a std::runtime_error. Throwing an exception from resource_retriever instead makes for a more useful error message. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
This was referenced Oct 16, 2020
jacobperron
added a commit
that referenced
this pull request
Oct 16, 2020
Otherwise, ament_index_cpp will throw a std::runtime_error. Throwing an exception from resource_retriever instead makes for a more useful error message. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
jacobperron
added a commit
that referenced
this pull request
Oct 16, 2020
jacobperron
added a commit
that referenced
this pull request
Oct 16, 2020
jacobperron
added a commit
that referenced
this pull request
Oct 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, ament_index_cpp will throw a std::runtime_error.
Throwing an exception from resource_retriever instead makes for a more useful error message.