Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install headers to include/${PROJECT_NAME} #72

Merged
merged 2 commits into from
Feb 5, 2022
Merged

Install headers to include/${PROJECT_NAME} #72

merged 2 commits into from
Feb 5, 2022

Conversation

sloretz
Copy link
Contributor

@sloretz sloretz commented Feb 4, 2022

Part of ros2/ros2#1150 - this installs resource_retriever's header files to a unique directory in a merged workspace.

I also removed the dependency on ament_cmake_ros since it wasn't being used.

@sloretz
Install headers to include/${PROJECT_NAME}
cf5b995 
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
@sloretz sloretz self-assigned this Feb 4, 2022
@sloretz
Copy link
Contributor Author

sloretz commented Feb 4, 2022

Turns out I don't need to do anything with libcurl_vendor. It's includes are already installed to a unique directory: opt/libcurl_vendor/include

clalancette
clalancette requested changes Feb 4, 2022
View reviewed changes
resource_retriever/CMakeLists.txt Outdated Show resolved Hide resolved
@sloretz
Put back ament_cmake_ros for BUILD_SHARED_LIBS option
2bc9430 
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
clalancette
clalancette approved these changes Feb 4, 2022
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with green CI.

@sloretz
Copy link
Contributor Author

sloretz commented Feb 4, 2022 •
edited
Loading

CI (build: --packages-above-and-dependencies resource_retriever test: --packages-select resource_retriever)

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status -- Edit: network error, will re-run a bit later error : downloading 'https://github.com/ros/console_bridge/archive/1.0.1.tar.gz' failed
    • re-run: Build Status

@sloretz sloretz merged commit d9eb388 into ros2 Feb 5, 2022
@sloretz sloretz deleted the sloretz__resource_retriever__include_projectname branch February 5, 2022 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

Assignees

@sloretz sloretz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sloretz @clalancette