Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash on 0 free joints, opens empty window #178

Merged
merged 1 commit into from Jan 19, 2017

Conversation

@bmagyar
Copy link
Contributor

bmagyar commented Jan 19, 2017

Fixes #176 by simply skipping the math when having to return 0 rows. GUI opens up empty as it did before the gridlayout changes.

@bmagyar

This comment has been minimized.

Copy link
Contributor Author

bmagyar commented Jan 19, 2017

I chopped off all parts of my iCub urdf and left only the pelvis, behold:

screenshot from 2017-01-19 15 58 15

@wjwwood

This comment has been minimized.

Copy link
Member

wjwwood commented Jan 19, 2017

lgtm, thanks!

@wjwwood wjwwood merged commit 258de29 into ros:kinetic-devel Jan 19, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.