Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mandatory dependency on rostest #58

Closed
jvgomez opened this issue Aug 30, 2016 · 2 comments
Closed

Mandatory dependency on rostest #58

jvgomez opened this issue Aug 30, 2016 · 2 comments

Comments

@jvgomez
Copy link

jvgomez commented Aug 30, 2016

Hi,

I have noticed that the dependency on rostest is always there. In other packages (TF example) rostest is only find-packaged if CATKIN_ENABLE_TESTING is true. Reference issue

I wonder whether there is a reason for not doing the same in this package.

@jvgomez
Copy link
Author

jvgomez commented Nov 1, 2016

Ping. I am interested on knowing the answer to know whether I should do a PR with the fix here (to indigo-devel) or to meta-ros with the corresponding patch.

@tfoote
Copy link
Member

tfoote commented Nov 1, 2016

Moving the rostest dependency inside the conditional is better. You can then also move it to be a test_depend in the package.xml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants