Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow arguments in EDITOR env in zsh rosed #144

Merged
merged 1 commit into from
Apr 20, 2017
Merged

allow arguments in EDITOR env in zsh rosed #144

merged 1 commit into from
Apr 20, 2017

Conversation

sztupi
Copy link
Contributor

@sztupi sztupi commented Apr 19, 2017

in zsh executing
$EDITOR ${arg}
fails if EDITOR has space in it (as zsh escapes the content),
e.g. EDITOR='emacs -nw' becomes 'emacs\ -nw'

wjwwood
wjwwood approved these changes Apr 19, 2017
View reviewed changes
Copy link
Member

@wjwwood wjwwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me.

@dirk-thomas
Copy link
Member

Thanks for the patch.

@dirk-thomas dirk-thomas merged commit 9715503 into ros:lunar-devel Apr 20, 2017
@dirk-thomas dirk-thomas mentioned this pull request Oct 26, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjwwood wjwwood wjwwood approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sztupi @dirk-thomas @wjwwood