[roswtf] Better msg replacement for 'No package or stack in context'. #1505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When there's no ROS pkg is found on the current directory when `roswtf` is run, a message `No package or stack in context` appears. This message is not useful IMO because "context" is unclear. This PR suggests clearer message. **How to reproduce the behavior** ``` $ cd ~ $ roswtf : No package or stack in context : $ rosversion roswtf 1.12.14 ```
|
Thanks for the improvement. |
tahsinkose
pushed a commit
to tahsinkose/ros_comm
that referenced
this pull request
Apr 15, 2019
…ros#1505) When there's no ROS pkg is found on the current directory when `roswtf` is run, a message `No package or stack in context` appears. This message is not useful IMO because "context" is unclear. This PR suggests clearer message. **How to reproduce the behavior** ``` $ cd ~ $ roswtf : No package or stack in context : $ rosversion roswtf 1.12.14 ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there's no ROS pkg is found on the current directory when
roswtfis run, a messageNo package or stack in contextappears. This message is not useful IMO because what "context" means is unclear and is not something clearly explained anywhere in ROS documents.This PR suggests clearer message.
How to reproduce the behavior